slider: handle mouse wheel events#2565
Merged
Merged
Conversation
hecrj
approved these changes
Sep 13, 2024
hecrj
left a comment
hecrj
left a comment
Member
There was a problem hiding this comment.
Thanks!
I made a change to only enable slider scrolling when the Ctrl modifier is pressed. This way, we avoid accidental slider changes when inside a scrollable.
Contributor
Author
|
Oh. I was trying to emulate Windows-specific behavior here, specifically the app I was replacing with my Iced project. Of course, users can adjust, but the initial friction will be there. So I suppose there's no way for a widget inside another to prevent the outer widget from capturing its events? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make
slider+vertical_sliderhandle mouse wheel events -- i.e. when hovered, scrolling the mouse wheel will modify the slider.Question: currently the slider is incr/decremented by
self.stepfor bothScrollDelta::PixelsandScrollDelta::Lines. This seems appropriate forLines, but I'm not sure aboutPixels. (It felt fine to me when testing, but I'm not sure what the "expected" behaviour is.)